Feature #78

avatar

user defined highlights

Added by Lycaon - 5959 days ago. Updated 5325 days ago.

Status:Closed Start:
Priority:High Due date:
Assigned to:avatarChris Le Sueur % Done:

100%
Category:Frontend GNOME
Target version:0.7.2
Complexity:

Medium
Votes: 0

Description

The highlightlist is not accessible in the gnome front-end. Tested it within windows and Ubuntu 8.04 LTS 32/64Bit edition.
A further suggestion is allowing Regualar expressions within the highlight list.

Associated revisions

Revision e15af3bcb131e4b9ae558381f5e65d212d8c04f7
Added by Chris Le Sueur 5325 days ago

Support custom highlight words (closes: #78)

Initial commit. Additional highlight words are required to be separated by non-word
characters from surrounding text. A word can be defined as a regex by surroundng it
with forward slashes. (In this case there is not yet any error checking). In the
preferences UI, each new line specifies a new highlight word, so they can contain
spaces.

Signed-off-by: Mirco Bauer <>

History

Updated by Mirco Bauer 5959 days ago

avatar

The highlight list is disabled because it's not implemented, thus I changed this ticket to "enhancement".

Updated by Mirco Bauer 5933 days ago

avatar

Highlight should allow to be channel specific. Also highlights should have an exclude list.

Updated by Mirco Bauer 5400 days ago

avatar
  • Assigned to changed from Mirco Bauer to Chris Le Sueur
  • Target version changed from 0.8 to 0.7.2
  • Complexity set to Medium

Updated by Chris Le Sueur 5398 days ago

avatar
  • % Done changed from 0 to 50

Initial stuff is done, but no support yet for channel-specific or excluding highlights.

Updated by Mirco Bauer 5397 days ago

avatar

Chris Le Sueur wrote:

Initial stuff is done, but no support yet for channel-specific or excluding highlights.

For extra features, please make new tickets and set this one to 100% + resolved + git repo + git branch name, then I can merge it into master.

Updated by Chris Le Sueur 5397 days ago

avatar
  • % Done changed from 50 to 100

git://gitorious.org/~fish-face/smuxi/smuxi-face.git
feature/#78_customhighlights

Updated by Mirco Bauer 5397 days ago

avatar
  • Status changed from New to Feedback
Very promising branch! For the reference here some comments regards the code (which I said on IRC):
22:04:42 <meebey> Fish-Face: ok, the first thing you need to read about is: git rebase -i to squash commits
...
22:12:12 <meebey> Fish-Face: white space errors are: mixed white space (space with tabs)
22:12:29 <meebey> Fish-Face: or trailing white space, say behind code;
...
22:23:11 <meebey> Fish-Face: about coding style, local variables are _always_ lower cased
22:23:40 <meebey> Fish-Face: e.g. +            string[] HighlightWords = 
...
22:26:05 <meebey> Fish-Face: its ok to use C# 2.0 and 3.0 language (compile time) features
22:26:07 <meebey> Fish-Face: for example:
22:26:12 <meebey> +            ((Gtk.TextView)_Glade["HighlightWordsTextView"]).Buffer.Changed += new EventHandler(_OnChanged);
22:26:17 <meebey> Fish-Face: -> += _OnChanged;

Updated by Chris Le Sueur 5325 days ago

avatar
  • Status changed from Feedback to Closed

Also available in: Atom PDF