Bug #112

avatar

URL handling

Added by Ryan Smith-Evans 5742 days ago. Updated 5635 days ago.

Status:Closed Start:
Priority:Urgent Due date:
Assigned to:avatarMirco Bauer % Done:

0%

Category:Frontend GNOME
Target version:0.6.3
Complexity:

Found in Version:

Votes: 0

Description

Something appears to be breaking the URL handler for clicking links. Appears to happen in the Smuxi channel only.

History

Updated by Mirco Bauer 5740 days ago

avatar

I can't reproduce this issue.

Updated by Mirco Bauer 5700 days ago

avatar
  • Status changed from New to Assigned

ajorg pointed me to this issue and I was checking what is the cause... I thought for a while gnome vfs is the issue, but it's not!
I can reproduce this issue and I found the cause of it!
When you select an user in the userlist from that point on opening URLs will fail (be ignored actually).

This is caused by a check in the opening URL code:
489                if (e.Event.Button == 3 && _PersonTreeView.Selection.CountSelectedRows() > 1) { 
490                    e.RetVal = true; 
491                } 
and from an HasSelection override that says the page has a selection if an user is selected in GroupChatView.cs:
59            public override bool HasSelection { 
60                get { 
61                    return base.HasSelection || _PersonTreeView.Selection.CountSelectedRows() > 0; 
62                } 
63            }

SVN revision r327 and r330 show that affected code and a fix that was done only to one place. That might fix this issue, have to test.

Updated by Mirco Bauer 5635 days ago

avatar
  • Status changed from Assigned to Closed
  • 1 set to fixed

It was not as simple as I expected instead it was pretty challenging! Changing the HasSelection property causes regressions in other areas because they rely on that behaviour. The fix was to destroy the selection when we leave the user list, the URL code checks now for selected text only and the user list context menu does not grab the focus anymore (else we would loose the selection). Fixed in SVN revision r436

Also available in: Atom PDF