Bug #1017
Nicknames of others should not trigger highlights
| Status: | New | Start: | 01/18/2015 | |
| Priority: | Low | Due date: | ||
| Assigned to: |  Mirco Bauer |
% Done: | 0% |
|
| Category: | Engine | |||
| Target version: | - | |||
| Complexity: | Medium |
Found in Version: | ||
| Votes: | 0 |
Description
when using an irc bouncer, if you talk from another client it will show up as a highlight on smuxi as shown here: http://puu.sh/eGZ0l/1f2a4cbcea.png
Related issues
| duplicated by Smuxi - Bug #939 | nickname of others triggers highlight and notification | New | 01/12/2014 |
History
Updated by Mirco Bauer 3594 days ago
- Subject changed from Name highlight - Incorrect range to Nicknames of others should not trigger highlights
- Category changed from Frontend to Engine
- Target version set to 0.11.1
Updated by Mirco Bauer 3479 days ago
- Target version deleted (
0.11.1) - Complexity changed from Low to Medium
Not sure why I have set complexity to low, but the issue is that the nickname regex for highlights is matched again's the complete received message, including the nickname part. This has to be fixed. This branch on github is related to this issue: https://github.com/meebey/smuxi/tree/experiments/msg_sender_parser
Updated by Mirco Bauer 3479 days ago
https://github.com/meebey/smuxi/blob/master/src/Engine/Messages/MessageBuilder.cs#L457
This would need to only match against the body of the message, not all parts of it.