Bug #323

avatar

Partial self triggered highlights

Added by Mirco Bauer 5394 days ago. Updated 5261 days ago.

Status:Closed Start:01/28/2010
Priority:Normal Due date:
Assigned to:avatarMirco Bauer % Done:

100%

Category:Engine IRC
Target version:0.7.1
Complexity:

Low

Found in Version:

Votes: 0

Description

You usually can't trigger self triggered highlights (if you say your own nick for example), but if combined with other formattings you will get a partial highlight.
This triggers the issue:
Hi $your_nick, _this_ triggers partial self highlights!

Related issues

related to Smuxi - Bug #344 Inconsistent highlight coloring Closed 02/08/2010

Associated revisions

Revision 6215995285e74fba4fe0c4147d6296c1405475e9
Added by Mirco Bauer 5394 days ago

Fixed partial self triggered highlights (closes: #323)

History

Updated by Mirco Bauer 5393 days ago

avatar
  • Status changed from New to Closed
  • % Done changed from 0 to 100

Updated by Mirco Bauer 5387 days ago

avatar
  • Status changed from Closed to Assigned
  • Target version changed from 0.7.1 to 0.7.2
Reopened, seems like this isn't completely fixed.
Half of this message for example was orange and the rest (behind "*is*") not:
20:49:06 <directhex> meebey, thanks for your help on this btw. i want to get it as right as possible now, despite mad upstream, so that a) when it *is* debianable, it's already correct in binary terms, and b) make it so there's no delta between ubuntu/unofficial packages and eventual debian packages

Updated by Mirco Bauer 5383 days ago

avatar

Actually I think this partial highlight is wanted. The idea was to only highlight the word that triggered it, but splitting the message down into smaller pieces would add overhead to the message size as the object tree grows. So the fix would be to implement that "only highlight words" instead of the message "chunk" that contains the highlight word.

Updated by Mirco Bauer 5261 days ago

avatar
  • Status changed from Assigned to Closed
  • Target version changed from 0.7.2 to 0.7.1

This issue was already solved but didn't address the inconsistent highlight issue as reported in #344, thus closing this now.

Also available in: Atom PDF