Feature #146

avatar

Please add right-click menu to queries

Added by Redmine Admin 5579 days ago. Updated 5212 days ago.

Status:Closed Start:
Priority:Low Due date:
Assigned to:avatarClément Bourgeois % Done:

100%

Category:Frontend GNOME
Target version:0.7
Complexity:

Votes: 0

Description

Hi,

please add a right-click context menu in private message windows, with common operations such as Whois, CTCP Version, CTCP Ping, and so on.

Thank you,
Davide

ticket146.patch (4.3 KB) David Paleino, 01/03/2009 11:57 AM

Associated revisions

Revision 7d99797f0e56f6ab87dea68356f038174fd9a7af
Added by Clément Bourgeois 5212 days ago

Implemented IRC popup menu for queries (closes: #146)

Changes based on work done by David Paleino (patch sent 03/01/2009)

Signed-off-by: Mirco Bauer <>

Revision 5a76189859ddc1a6ccbd07f3121f737eb4b4e583
Added by Clément Bourgeois 5212 days ago

Show CTCP replies on query tabs when available (closes: #269, refs: #146)

Signed-off-by: Mirco Bauer <>

History

Updated by David Paleino 5579 days ago

avatar
  • Status changed from New to Assigned

Updated by anonymous - 5578 days ago

avatar

Hello Mirco,
I've implemented this in Git branch 146.

It needs the patch for #147 to be applied first, as this one depends on methods created there.

Please apply this to trunk/, and tell me when I can close the ticket and merge the branches into my git's master.

Kindly,
David

Updated by David Paleino 5578 days ago

avatar
  • Status changed from Assigned to Closed
  • 1 set to fixed

Updated by David Paleino 5578 days ago

avatar
  • Status changed from Closed to Feedback
  • 1 deleted (fixed)

Updated by David Paleino 5578 days ago

avatar
  • Status changed from Feedback to New

Updated by David Paleino 5578 days ago

avatar
  • Status changed from New to Assigned

Updated by Mirco Bauer 5578 days ago

avatar
Patch looks good except the abuse of copying variables to fields why they simply exist in the base class already, please remove these:
private PersonChatModel    _personChat; 
private IrcProtocolManager _IrcProtocolManager; 
Also don't do this:
using Gtk;

that causes conflicts with types and Gtk is very short to type.

Updated by Mirco Bauer 5215 days ago

avatar
  • Target version changed from 0.8 to 0.7

Updated by Mirco Bauer 5213 days ago

avatar
  • Assigned to changed from David Paleino to Clément Bourgeois

Updated by Clément Bourgeois 5212 days ago

avatar
  • % Done changed from 0 to 100

Everything is implemented now. You can merge for testing.

http://moonpyk.ath.cx/git/?p=smuxi.git;a=commit;h=ec0f54837eb1c96a1846401e6a613ea0016f4d6a

git://moonpyk.ath.cx/smuxi.git -> features/#146_Please_add_right-click_menu_to_queries

Updated by Clément Bourgeois 5212 days ago

avatar
  • Status changed from Assigned to Closed

Also available in: Atom PDF