Bug #658

avatar

Connection looping with NullReferenceException on server

Added by Jelmer Vernooij 988 days ago. Updated 269 days ago.

Status:Feedback Start:12/08/2011
Priority:Urgent Due date:
Assigned to:avatarMirco Bauer % Done:

0%

Category:Engine IRC
Target version:-
Complexity:

Found in Version:

git

Votes: 0

Description

Connecting to smuxi-server this morning seems to be triggering a null reference exception on the server. That in turn then causes the server to reconnect to the IRC server, after which it again crashed, over and over again until I killed it.

System.NullReferenceException: Object reference not set to an instance of an object
  at Smuxi.Engine.IrcProtocolManager._OnQueryNotice (System.Object sender, Meebey.SmartIrc4net.IrcEventArgs e) [0x00000] in <filename unknown>:0
  at Meebey.SmartIrc4net.IrcClient._Event_NOTICE (Meebey.SmartIrc4net.IrcMessageData ircdata) [0x00000] in <filename unknown>:0
  at Meebey.SmartIrc4net.IrcClient._HandleEvents (Meebey.SmartIrc4net.IrcMessageData ircdata) [0x00000] in <filename unknown>:0
  at Meebey.SmartIrc4net.IrcClient._Worker (System.Object sender, Meebey.SmartIrc4net.ReadLineEventArgs e) [0x00000] in <filename unknown>:0 
  at (wrapper delegate-invoke) <Module>:invoke_void__this___object_ReadLineEventArgs (object,Meebey.SmartIrc4net.ReadLineEventArgs)
  at (wrapper delegate-invoke) <Module>:invoke_void__this___object_ReadLineEventArgs (object,Meebey.SmartIrc4net.ReadLineEventArgs)
  at Meebey.SmartIrc4net.IrcConnection.ReadLine (Boolean blocking) [0x00000] in <filename unknown>:0
  at Meebey.SmartIrc4net.IrcConnection.Listen (Boolean blocking) [0x00000] in <filename unknown>:0
  at Meebey.SmartIrc4net.IrcConnection.Listen () [0x00000] in <filename unknown>:0
  at Smuxi.Engine.IrcProtocolManager._Listen () [0x00000] in <filename unknown>:0

Related issues

related to Smuxi - Feature #38 send notices from users to channels and querys where useful Closed

Associated revisions

Revision e85b8d0ce1bb522a677495af7af773ab78beed01
Added by Mirco Bauer 988 days ago

[Engine-IRC] Fixed potential NullReferenceException in IrcProtocolManager._OnQueryNotice() (references: #658, #38)

History

Updated by Mirco Bauer 988 days ago

avatar
  • Category set to Engine IRC
  • Assigned to set to Mirco Bauer
  • Priority changed from Normal to Urgent
  • Target version set to 0.8.9

Nice catch, you found a parser bug in the IRC lib. Though I will need the line that triggered it, with smuxi-server -d or smuxi-frontend-gnome -d it should log the that was received before the crash.

Could it be that you connect Smuxi to a bouncer or some other form of unusual IRC server? At least that is what likes to bend the IRC RFC or even violates it which the IRC lib is not so forgiveful about. Whatever the issue is, the IRC lib needs to cope with it in a non-exception way :-)

Updated by Mirco Bauer 988 days ago

avatar

OK, I spotted a potential NullReferenceException in the code for group chats without users inside (like disabled chat after kick or connection loss). I will fix this one and this might solve the issue already for you.

Updated by Mirco Bauer 988 days ago

avatar

This is a regression caused by feature #38

Updated by Mirco Bauer 988 days ago

avatar

Please try if e85b8d0ce1bb522a677495af7af773ab78beed01 fixes this for you

Updated by Jelmer Vernooij 988 days ago

avatar

Thanks! I'll give it a try tomorrow.

Updated by Mirco Bauer 985 days ago

avatar

bzr revision 39 is now available as daily build, LP buildds were lagging behind for almost a day.

Updated by Mirco Bauer 974 days ago

avatar

Ping: is this issue fixed for you?

Updated by Mirco Bauer 971 days ago

avatar
  • Target version changed from 0.8.9 to 0.10

Updated by Mirco Bauer 943 days ago

avatar
  • Status changed from New to Feedback

Updated by Mirco Bauer 269 days ago

avatar
  • Target version deleted (0.10)

Also available in: Atom PDF