Feature #472

avatar

Theme sensitive application icon

Added by Dag Odenhall 4967 days ago. Updated 4488 days ago.

Status:Closed Start:09/06/2010
Priority:Normal Due date:
Assigned to:avatarMirco Bauer % Done:

100%

Category:Frontend GNOME
Target version:0.8.9
Complexity:

Medium

Votes: 0

Description

If a (GNOME) theme provides an application icon for Smuxi, it should be used in place of the canonical one wherever applicable.

Associated revisions

Revision e5d694e3ec01656546791b1a43762e4166fa5231
Added by Mirco Bauer 4514 days ago

[Frontend-GNOME] Load PNG instead of SVG images, honor GTK+ icon themes and install icons into correct places

- Only load pre-scaled PNG image files in Smuxi so the SVG pixbuf loader
for GDK is no longer needed. (closes: #230, #304)
- Load icons using Gtk.IconTheme to honor GTK+ icon themes. (closes: #472)
- Install SVG and PNGs into correct locations as per
GNOME Goal: Install theme-friendly icons [0]. (closes: #503)

http://live.gnome.org/GnomeGoals/AppIcon

History

Updated by Mirco Bauer 4967 days ago

avatar
  • Tracker changed from Bug to Feature

Updated by Mirco Bauer 4967 days ago

avatar
  • Category changed from Frontend Curses to Frontend GNOME
  • Complexity set to Medium

Updated by Dag Odenhall 4966 days ago

avatar

This already works if the theme provides an icon for smuxi-frontend-gnome.svg. I think a best practice is to leave out the extension in the .desktop however; example from Empathy:

Icon=empathy

Screenshots: http://imgur.com/a/Id0KJ/smuxi_faenza_icons

Remaining issues: The Notification Area icon is not affected by the theme.

Updated by Dag Odenhall 4966 days ago

avatar

Just realized the tab icons ignore the theme as well. Using Gtk stock icons should solve this.

Updated by Dag Odenhall 4963 days ago

avatar
<donri> meebey: Gtk.IconTheme
<donri> meebey: bool Gtk.IconTheme.Default.HasIcon("smuxi-frontend-gnome")
<donri> meebey: Gdk.Pixbuf Gtk.IconTheme.Default.LoadIcon("smuxi-frontend-gnome", 24, 0)
<donri> if null use old loading mechanism
<donri> Not sure if that's needed to use theme icons on the tabs
<donri> Mainly because I don't know how you currently load 'em :)

Updated by Mirco Bauer 4962 days ago

avatar
  • Target version set to 0.10

Updated by Mirco Bauer 4514 days ago

avatar
  • Status changed from New to Closed
  • % Done changed from 0 to 100

Updated by Mirco Bauer 4488 days ago

avatar
  • Target version changed from 0.10 to 0.8.9

Also available in: Atom PDF