Bug #311

avatar

/join suddenly stops working

Added by Ingo Saitz 5154 days ago. Updated 5144 days ago.

Status:Closed Start:01/22/2010
Priority:Immediate Due date:
Assigned to:avatarMirco Bauer % Done:

100%

Category:Engine IRC
Target version:0.7.1
Complexity:

Medium

Found in Version:

Votes: 0

Description

after closing a tab by klicking it with the middle mouse button (which probably was not the trigger), i could not /join any channel on all ircnets i was connected to. /reconnect did not help to fix the problem, only closing the server tab with all its channels and reopening it using quick connect from the menu.
after that i could use /join again on the new server connection but still not on the old server connections.
/quote join #channel worked nevertheless.


Related issues

related to Smuxi - Bug #251 /join is sometimes not doing anything at all Closed 12/25/2009
related to Smuxi - Bug #240 excess flood caused by joining many channels at once Closed 11/20/2009
duplicated by Smuxi - Bug #318 manual /reonnect did not issue /join commands Closed 01/24/2010

Associated revisions

Revision 1ab5cca803ac70499d721c7ebef82d8009a99b39
Added by Mirco Bauer 5144 days ago

Reset the join queue when disconnecting and be verbose when the delay kicks in (closes: #311)

The /join command sometimes stopped completly working.
A netsplit -> excess flood -> rejoins -> excess flood could leave old and
unfinished join attempts in _ActiveChannelJoinList behind causing the join
queue to block forever.

History

Updated by Mirco Bauer 5152 days ago

avatar
  • Category set to Engine IRC
  • Assigned to set to Mirco Bauer
  • Target version set to 0.7.2
  • Complexity set to Medium

Ok, I could track this issue down to this:
http://git.qnetp.net/?p=smuxi.git;a=blob;f=src/Engine-IRC/Protocols/Irc/IrcProtocolManager.cs;h=e969dc314e55bb931d34b83b3f63c762b6a3d0d7;hb=HEAD#l2618

The NAMES reply event can be raised multiple times for big channels, leaving duplicate entries in _JoinChannelList behind. The next join attempt will then believe there are still on-going joins and thus never happens.

Updated by Mirco Bauer 5146 days ago

avatar
  • Priority changed from Normal to Immediate
  • Target version changed from 0.7.2 to 0.7.1

Updated by Mirco Bauer 5144 days ago

avatar
  • Status changed from New to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF