Bug #311
/join suddenly stops working
Status: | Closed | Start: | 01/22/2010 | |
Priority: | Immediate | Due date: | ||
Assigned to: | Mirco Bauer | % Done: | 100% |
|
Category: | Engine IRC | |||
Target version: | 0.7.1 | |||
Complexity: | Medium |
Found in Version: | ||
Votes: | 0 |
Description
after closing a tab by klicking it with the middle mouse button (which probably was not the trigger), i could not /join any channel on all ircnets i was connected to. /reconnect did not help to fix the problem, only closing the server tab with all its channels and reopening it using quick connect from the menu.
after that i could use /join again on the new server connection but still not on the old server connections.
/quote join #channel worked nevertheless.
Associated revisions
Revision 1ab5cca803ac70499d721c7ebef82d8009a99b39
Reset the join queue when disconnecting and be verbose when the delay kicks in (closes: #311)
The /join command sometimes stopped completly working.
A netsplit -> excess flood -> rejoins -> excess flood could leave old and
unfinished join attempts in _ActiveChannelJoinList behind causing the join
queue to block forever.
History
Updated by Mirco Bauer 5420 days ago
- Category set to Engine IRC
- Assigned to set to Mirco Bauer
- Target version set to 0.7.2
- Complexity set to Medium
Ok, I could track this issue down to this:
http://git.qnetp.net/?p=smuxi.git;a=blob;f=src/Engine-IRC/Protocols/Irc/IrcProtocolManager.cs;h=e969dc314e55bb931d34b83b3f63c762b6a3d0d7;hb=HEAD#l2618
The NAMES reply event can be raised multiple times for big channels, leaving duplicate entries in _JoinChannelList behind. The next join attempt will then believe there are still on-going joins and thus never happens.
Updated by Mirco Bauer 5413 days ago
- Priority changed from Normal to Immediate
- Target version changed from 0.7.2 to 0.7.1
Updated by Mirco Bauer 5411 days ago
- Status changed from New to Closed
- % Done changed from 0 to 100
Applied in changeset 1ab5cca803ac70499d721c7ebef82d8009a99b39.