Bug #112
URL handling
Status: | Closed | Start: | ||
Priority: | Urgent | Due date: | ||
Assigned to: | Mirco Bauer | % Done: | 0% |
|
Category: | Frontend GNOME | |||
Target version: | 0.6.3 | |||
Complexity: | Found in Version: | |||
Votes: | 0 |
Description
Something appears to be breaking the URL handler for clicking links. Appears to happen in the Smuxi channel only.
History
Updated by Mirco Bauer 5915 days ago
- Status changed from New to Assigned
ajorg pointed me to this issue and I was checking what is the cause... I thought for a while gnome vfs is the issue, but it's not!
I can reproduce this issue and I found the cause of it!
When you select an user in the userlist from that point on opening URLs will fail (be ignored actually).
489 if (e.Event.Button == 3 && _PersonTreeView.Selection.CountSelectedRows() > 1) { 490 e.RetVal = true; 491 }and from an HasSelection override that says the page has a selection if an user is selected in GroupChatView.cs:
59 public override bool HasSelection { 60 get { 61 return base.HasSelection || _PersonTreeView.Selection.CountSelectedRows() > 0; 62 } 63 }
SVN revision r327 and r330 show that affected code and a fix that was done only to one place. That might fix this issue, have to test.
Updated by Mirco Bauer 5850 days ago
- Status changed from Assigned to Closed
- 1 set to fixed
It was not as simple as I expected instead it was pretty challenging! Changing the HasSelection property causes regressions in other areas because they rely on that behaviour. The fix was to destroy the selection when we leave the user list, the URL code checks now for selected text only and the user list context menu does not grab the focus anymore (else we would loose the selection). Fixed in SVN revision r436